Hello everyone! This obnoxious header will stay around during Dashboard Awareness Week!

Check out why in the Dashboard Awareness Forum Thread!

Happy browsing!

TR_FilePatcher still missing some script identifiers

Type: 

Bug

Severity: 

Normal

Game version: 

Morrowind (Steam)

Concerns: 

Tamriel_Data

Found in Version: 

Status: 

Description: 

I tried running the TheBareNecessities_TamrielRebuilt.esp (available here: http://www.nexusmods.com/morrowind/mods/43365) through the TR_FilePatcher. It seems to have missed all the IDs in the BN_ related scripts (examples below), and crashes the game without these.

This MIGHT be user error though...when I ran the patcher it kept asking for Translation.txt and when I couldn't find it, I just created my own. But it seems to have fixed the .ESM dependencies okay, so I'm not sure. Also, is it just me, or are there some random .nifs thrown in here that shouldn't be?

set AloeJuice to ( Player->GetItemCount, "TR_m3_juice1_i3-128-ind" )
    set CheapWine to ( Player->GetItemCount, "TR_potion_wine_03" )
    set ColovianBattlewine to ( Player->GetItemCount, "tr_potion_colovian_wine" )
    set Goya to ( Player->GetItemCount, "TR_potion_bourbon.nif" ) --> .nif wha??
    set GreefStonewareJug to ( Player->GetItemCount, "TR_m3_stw_jug_greef" )
    set HamumRootJuice to ( Player->GetItemCount, "TR_m3_juice2_i3-128-ind")
    set HollyWine to ( Player->GetItemCount, "TR_m3_juice4_i3-128-ind" )
    set Jagga to ( Player->GetItemCount, "TR_potion_jagga.nif" )
    set KvatchWine to ( Player->GetItemCount, "TR_potion_wine_05" )
    set NibenayValleyHolyWine to ( Player->GetItemCount, "TR_potion_wine_01" )
    set RestorativeSpringWater to ( Player->GetItemCount, "TR_m3_water1_m1-128-ind" )
    set ScampBroth to ( Player->GetItemCount, "TR_m1_Tel_Scampskinsoup_AA" )
    set SpoiledSutchWine to ( Player->GetItemCount, "tr_m3_q_A5_spoiledwine" )
    set SurilieBrothers to ( Player->GetItemCount, "TR_potion_wine_04" )
    set SutchWine to ( Player->GetItemCount, "TR_potion_wine_06" )
    set SweetpulpJuice to ( Player->GetItemCount, "TR_m3_juice3_i3-128-ind" )
    set TamikasCellarFineWine to ( Player->GetItemCount, "TR_potion_wine_02" )
    set TramaTea to ( Player->GetItemCount, "TR_i2_tramatea" )
    set Ungorth to ( Player->GetItemCount, "TR_potion_orc_liquor.nif" )
    set Veig to ( Player->GetItemCount, "TR_potion_ale_snowberry.nif" )
;    set VintageColovianBattlewine to ( Player->GetItemCount, "tr_potion_m3-771_wine" )
    set WayrestSpicedWine to ( Player->GetItemCount, "TR_potion_wayrest_wine" )

set AlitMeat to ( Player->GetItemCount, "TR_Ingred_Meat_Alit" )
;    set BreadDough to ( Player->GetItemCount, "TR_i3-244_Dough" )
    set ColovianLoaf1 to ( Player->GetItemCount, "TR_Ingred_Bread_01" )
    set ColovianLoaf2 to ( Player->GetItemCount, "TR_Ingred_Bread_01b" )
    set CookedDurzogMeatTR to ( Player->GetItemCount, "TR_Ingred_Meat_Durzog" )
    set CookedHoundMeat to ( Player->GetItemCount, "TR_Ingred_Meat_Nix" )
    set CookedRatMeat to ( Player->GetItemCount, "TR_Ingred_Meat_Rat" )
    set Cookie1 to ( Player->GetItemCount, "TR_Ingred_Cookie_01" )
    set Cookie2 to ( Player->GetItemCount, "TR_Ingred_Cookie_02" )
    set DeshaanBread1 to ( Player->GetItemCount, "TR_Ingred_Bread_02" )
    set DeshaanBread2 to ( Player->GetItemCount, "TR_Ingred_Bread_03" )
    set DryFish1 to ( Player->GetItemCount, "TR_Ingred_Dryfish01" )
    set DryFish2 to ( Player->GetItemCount, "TR_Ingred_Dryfish02" )
    set GuarMeat to ( Player->GetItemCount, "TR_Ingred_Meat_Guar" )
    set HamumRoot1 to ( Player->GetItemCount, "TR_Ingred_HamumRoot01")
    set HamumRoot2 to ( Player->GetItemCount, "TR_Ingred_HamumRoot02")
    set HamumRoot3 to ( Player->GetItemCount, "TR_Ingred_HamumRoot03")
    set HumanHeart to ( Player->GetItemCount, "TR_m3_humanheart_i3-453-aun")
    set KagoutiMeat to ( Player->GetItemCount, "TR_Ingred_Meat_Kagouti" )
    set KwamaMeat to ( Player->GetItemCount, "TR_Ingred_Meat_Kwama" )
    set MolecrabEgg to ( Player->GetItemCount, "TR_Ingred_Egg_Molecrab" )
    set NordicBoarMeat to ( Player->GetItemCount, "TR_Ingred_Meat_Boar" )
    set NordicMutton to ( Player->GetItemCount, "TR_Ingred_Meat_Mutton" )
    set OrnadaEgg to ( Player->GetItemCount, "TR_Ingred_Ornada_Egg" )
    set OrnadaMeat to ( Player->GetItemCount, "TR_Ingred_Ornada_Meat" )
    set ParastylusMeat to ( Player->GetItemCount, "TR_Ingred_Parastylus_Meat" )
    set RacerMeat to ( Player->GetItemCount, "TR_Ingred_Meat_Cliffracer" )
    set ScribPie to ( Player->GetItemCount, "TR_Ingred_Scrib_Pie" )
;    set ScribPieCorovob to ( Player->GetItemCount, "TR_m4_Ingred_Scrib_Pie_uni" )
    set WarmMeat to ( Player->GetItemCount, "TR_Ingred_Darkmeat" )

Comments

Translations.txt should be in

sirrah's picture

Translations.txt should be in the Morrowind base folder alongside the TR_Filepatcher.jar, and contains the mapping of old IDs to new, so using the wrong one will definitely cause problems.
Did you recreate the translation file, or did you just use a blank .txt? After a very cursory check in tes3cmd, it looks like the patcher translates the file correctly. It correctly replaces the references to .nif files as well, so I think the non-standard translation file is the culprit here.

Must be--I created a new

Kevaar's picture

Must be--I created a new blank one, because I couldn't find the original. The download only came with the patcher .jar. Where would I go to get the correct translation file?

I see one here though it

Rot's picture

I see one here though it might not be the most up to date (otherwise it's in the full PT Data download)

The .nif names are weird, yes, but... they're actually just the IDs that were given to those items! ._.

Replaced my Translation.txt

Kevaar's picture

Replaced my Translation.txt with a copy found in that thread--still crashing and the IDs still aren't updating properly when I look at them in the CS. By the error messages, the Region names are also borked.

Please do not use that one,

Atrayonis's picture

Please do not use that one, use the one included in the Tamriel_Data.7z. It's in the same directory as the filepatcher.

If it still demands to have a translation.txt, try this.

Okay, sirrah hooked me up

Kevaar's picture

Okay, sirrah hooked me up with the right Translation.txt. That changed the IDs. Then I had to recompile the scripts. I got some error messages that seem like they're related to the mod using MWSE for some of its scripting:

Script BN_InventoryMonitorScript
Script command "setx" not found on line 16.

Also a couple of these, not sure what's going on:
Script BN_InventoryMonitorScript
You need to end a script with "end scriptname"
Compiled script not saved

But while I didn't test too heavily, there's been no more crashes. So hopefully that's this bug solved.

A few play tests later...

Kevaar's picture

A few play tests later...

Loading the TR Sleep and Shelter or TR Water Sources (along with the basic TR patch and non-TR BN esps) means the mod doesn't even activate.
Loading the basic TR patch without the above two means only the sleep portion of the mod activates. Also a random crash that I can't reconstruct. Recompiling in the CS makes the mod complain of being unable to find "BN_HungerScriptActivate" and "BN_ThirstScriptActivate", which I assume are MWSE only codes it doesn't know what to do with.

Next step, try to recompile all these files in MWEdit instead...

HOKAY. After opening these

Kevaar's picture

HOKAY. After opening these things up in the MWEdit and mucking around, I figured out that I was working off of the BareNecessities_TR.esp, not the BareNecessities_TamrielRebuilt.esp. This is why the compiling errors were cropping up, as the _TR one is apparently an older file that no longer uses the same variables as the other .esps.

So that's one fix. But after that I still ran into the problem that while I could get hungry and thirsty and fill my water bottles, nothing sated my character's needs.

Further analysis reveals that the original Bare Necessities actually packages all the TR scripts required, but deactivates them (behind the ;comments). So I just went through those scripts and removed the ;'s. (I did not edit the "ReplaceWaterScript", because holy f***, TR why you use so many water statics. I'm not editting 1000+ lines of code just to make those work properly. Maybe on a rainy day! No pun intended...)

Soooo I ditched the _TamrielRebuilt plugin entirely, and the base file, just loading my patched version. Everything worked. My best guess is that the two files were somehow confusing each other, carrying the exact same codes minus the TR specific stuff. (Not sure why I couldn't load the _TamrielRebuilt patch all on its own, but...I couldn't. It would crash the game alone).

I'll take a look at the optional esps SleepAndShelter and WaterSources...later.