[Morrowind] Map1 Beta 2.0 World Error reporting

[6plus]

Cell: Helnim (25,1)
Location: ex shell of The Red Drake Inn (212459,9961,904)
Error: left/southern window does not touch the wall

[Howling_Snail]

1. Bahrammu: There is a platform that is too low to walk under. I have two screenshots of it:

[img]http://i234.photobucket.com/albums/ee181/pokemainiac/MGEScreenshot6.jpg[/img]

[img]http://i234.photobucket.com/albums/ee181/pokemainiac/MGEScreenshot7.jpg[/img]

2. Urlis Rock (19,27) is very glitchy, especially if you levitate around it, you can actually see inside it, and fall into it.

[abot]

TR_Map1.esm in_de_ship_cabindoor Firewatch, The Silver Serpent: Private Area 4284 3686 14800 "door is locked (only) from inside of the cabin"

TR_Map1.esm
NPC: TR_m1_Banviris
topic: Varyon Ancestral Tomb
INFO: To get there, go to the town of Ranyon-ruhn, and take the road to Firewatch. Keep going until you reach the fork where the right path leads leads up a hill. Atop that hill will you find the Varyon Tomb

[EDIT]updated
TR_Map1.esm TR_m1_Theobald00000000 Gah Sadrith (42,13) 345853 111021 1250 "learn learn from Mistress Eldale"
TR_Map1.esm TR_m1_Thelera_Tllas00000000 Gah Sadrith, Wetstone Tavern 4152 4599 15172
Name is Thelara Tllas, should probably be Thelera Tllas
Also, in Background topics maybe better use
"I am %name, owner of the Wetstone Tavern and proud brewer of the best Mazte in the Telvanni Isles."
than current
"I am Thelera Tllas, owner of the Wetstone Tavern and proud brewer of the best Mazte in the Telvanni Isles."
And I gave her some Mazte to sell...

Cheers, I am having a blast with TR quests
A question though: I've seen many so called "bleeding" scrolls, this does not annoy me at all but I was thinking this was one of your pet-peeves in showcases, does this mean you are gonna comb all these interiors again? (I hope not, I think you have plenty of better things to do already )

[EDIT]adding things while playing...
If you want to be compatible with Taddeus' rock replacer,

TR_Map1.esm terrain_rock_wg_12 Cell 23, 11 196065 97699 15172 lowering rock height to 2471 makes it compatible with Taddeus' rocks replacer (ex_cave_entrance_wg_01 nearby is no more blocked)

similarly
TR_Map1.esm ex_cave_door_01 Cell 22, 11 184796 91468 15172 436 moving terrain_rock_wg_10 near the door a little should solve problem

[arvisrend]

Ranyon-Ruhn, Brelar Gildaren's House: floating Furn_de_Kegstand.

Fixed - arvisrend, 28 Apr 2012

[abot]

A question though: I've seen many so called "bleeding" scrolls, this does not annoy me at all but I was thinking this was one of your pet-peeves in showcases, does this mean you are gonna comb all these interiors again? (I hope not, I think you have plenty of better things to do already )

quoting/answering myself: I've found the root of the problem, many of Schwaa's widely used scroll replacer meshes are centered on Z axis instead of being at about +3 units like standard scrolls. I'm fixing them for my personal use so no more bleeding, but maybe this info can be of use for someone else.

[EDIT]I had a glitch with the (wonderful, cheers!) quest for Master Mithras, I went through the 2 locked doors and got stuck by disableplayercontrols without the R_m1_q_Mithras_Double fireball being able to affect TR_m1_O_Goras Tarven, maybe a more safe approach could be something like this

Code: Select all

Begin TR_m1_q_RR_MQ_FinalShowdown

short state
float timer

If ( state == 0 )
	"TR_m1_q_Telaras Medreva"->StartCombat TR_m1_q_Azariah_Double
	TR_m1_q_Azariah_Double->sethealth 3
	disableplayercontrols
	set state to 1
	return
Endif

If ( state == 1 )
	If ( TR_m1_q_Azariah_Double->OnDeath )
		Journal TR_m1_RR_MQ_10 30
		set "TR_m1_q_Telaras Medreva".control to 2
		;"TR_m1_q_Telaras Medreva"->setshortblade 8
		"TR_m1_q_Telaras Medreva"->setmagicka 136
		"TR_m1_q_Telaras Medreva"->ForceGreeting
		set state to 2
	Endif
	return
Endif

If ( state == 2 )
	If ( "TR_m1_q_Telaras Medreva".control == 3 )
		If ( MenuMode == 0 )
			"TR_m1_O_Goras Tarven"->enable
			"TR_m1_O_Goras Tarven"->StartCombat Player
			"TR_m1_q_Telaras Medreva"->AITravel 3651, 4141, 1565
			set state to 3
		Endif
	Endif
	return
Endif

If ( state == 3 )
	If ( "TR_m1_O_Goras Tarven"->GetPos x >= 3700 )
		TR_m1_q_Mithras_Double->enable
		TR_m1_T_Mithras->disable
		TR_m1_q_Mithras_Double->PlaySound "mysticism hit"
		TR_m1_q_Mithras_Double->cast fireball "TR_m1_O_Goras Tarven"
		set state to 4
	Endif
	return
Endif

If ( timer >= 7 )
	TR_m1_q_Mithras_Double->cast fireball "TR_m1_O_Goras Tarven"
	"TR_m1_O_Goras Tarven"->ModCurrentHealth -1	; ensure he dies /abot
	set timer to 0
else
	set timer to ( timer + GetSecondsPassed )
endif

If ( "TR_m1_O_Goras Tarven"->GetHealth < 0.5 )
	set state to 5
	StopScript TR_m1_q_RR_MQ_FinalShowdown
	TR_m1_q_Mithras_Double->ForceGreeting
endif

End

[EDIT]fixed answering typo

[arvisrend]

abot Post Mon Mar 12, 2012 1:17 pm : all fixed except of the ex_cave_door_01 which I don't really understand (but I don't use replacers).

TR_Map1.esm TR_m1_Thelera_Tllas00000000 Gah Sadrith, Wetstone Tavern 4152 4599 15172
Name is Thelara Tllas, should probably be Thelera Tllas
Also, in Background topics maybe better use
"I am %name, owner of the Wetstone Tavern and proud brewer of the best Mazte in the Telvanni Isles."
than current
"I am Thelera Tllas, owner of the Wetstone Tavern and proud brewer of the best Mazte in the Telvanni Isles."
And I gave her some Mazte to sell...

She is now Thelara Tallas.

---

abot Post Sun Apr 08, 2012 12:34 pm : Why replace OnDeath by GetHealth? Also, why the "return"s? Wouldn't it be simpler to replace the lots of if-loops by a single if-elseif-elseif-... loop, instead of adding those returns?

[abot]

Why replace OnDeath by GetHealth?

OnDeath is a do once function returning 1 for a single frame. If for any reason that frame is skipped, it may not work.
A GetHealth < 1 (or something near to 0) is generally more safe, especially if coupled with a ModCurrentHealt -1 or similar to ensure NPC really dies and not remains with a 0.01 health or similar.

Also, why the "return"s? Wouldn't it be simpler to replace the lots of if-loops by a single if-elseif-elseif-... loop, instead of adding those returns?

Yes, probably a if-elseif-elseif (not excessively long though) would be equivalent or better, but I'd keep the returns before each elseif (if you don't have other code to execute after the last endif), for 2 reasons:
- you are 100% sure other elseif statements are always skipped (e.g. works even after a [url=http://www.uesp.net/wiki/Tes3Mod:Scripting_Pitfalls#ForceGreeting_Fallthrough]forcegreeting glitch[/url])
- you skip even parsing the rest of ifs pseudo-code structure. I've never been able to measure it in my scripts, but I remember someone (IIRC Zappara while developing temperature mod) reporting noticeable performance difference with/without returns in long global scripts.

[arvisrend]

I don't think that GetHealth is a good replacement for OnDeath. Give an enemy an ability of constant power regeneration and you'll notice that even when you kill him, his GetHealth is positive (it stops increasing a second or so after the death, but it is still positive!). I ran into that problem when debugging Arktwend long ago.

OnDeath, however, has never betrayed me (except for the fact that it can be accessed only once per NPC).

[abot]

I think there are pros and cons, so it is a matter of preference/varies with situation.

If you have some known health regeneration on NPC, increasing min health comparison value should work, e.g.

Code: Select all

if ( GetHealth < 5 )

instead of

Code: Select all

if ( GetHealth < 1 )

I often uses something like

Code: Select all

if ( GetHealth <= 0 )
; insert code take into account standard death or global script detached from target here
  return
endif

if ( GetHealthGetRatio <= 0.04 )   ; a good compromise for most NPC max health amount
  ModeCurrentHealth -10  ; do real kill if needed
endif
  return
endif

But you usually need a more complicated logic to ensure this remains a do once check, so I agree with you it may not be worth the effort to change from OnDeath, except in one case.

I think OnDeath, like most 1-frame/do-once events (CellChange...), may fail if it is called the same frame from multiple scripts (e.g. the first calling script in the list "consumes" the event resetting the event flag, so next script fails to notice).

As long as there are no both local and global scripts referencing the same NPC, OnDeath should work fine.

P.S. Thanks for enabling me to access to state-of-the-art files