Finally, an update! Worked out the quest logic and all the scripts, but put placeholder dialogue for now because I keep rewriting it. The quest should be fully working, the dialogue present will be replaced once I finalize it in my doc.
quest link: https://www.tamriel-rebuilt.org/claims/shipal-sharai-sense-apprehension
| Attachment | Size | Date |
|---|---|---|
 TR_ShiSha_darkfaerie_showcase.esp | 24.9 KB | 2024-09-25 12:29 |
2023-04-16 18:05
1 hour 51 min ago
Hey, I've checked the WIP file and structurally, it seems fine. Good job :) Just a couple of small things before we're able to give it a proper review with the finished dialogue:
1) If possible, try to use the T_Data default script variables `control` and `controlQ`. In Broldor's script, you declare your unique variables `jail` and `hideout`, but you can just use the default ones, as far as I can tell.
2) Change Broldor's OnDeath check so that it doesn't update a journal if you finish the quest by other means (journal stage >= 50)
3) You can give Marcy the `SoundFlies` script so that she's easier to find
4) Your file dirties a couple of scripts from other quests, you will have to clean this with TESAME or Enchanted Editor.
2024-02-09 18:35
1 day 5 hours ago
Update! I believe I've addressed all of the above, however something may have slipped my mind (I playtested the quest, but not too extensively). All the proper dialogue is in, I think it's ready for review. The quest structure changed a little bit, and I've also added a couple of JNS lines for Broldor because they wouldn't fit in the standard responses. He now tells you how to find them in Narsis if you return both the note and the sugar while not in the JNS.
2024-02-09 18:35
1 day 5 hours ago
found out I was using ` symbol instead of ' in my dialogue all this time...
fixed a bunch of validator issues, also I believe the cleaning did work this time
2023-04-16 18:05
1 hour 51 min ago
This is a very clean showcase! Sure, mechanically, this is a very simple quest, but it does meet the showcase requirements, the scripts work as they should, and it’s quite well written. At first I thought that Broldor seems a bit too forthcoming that the package he’s waiting for is illegal, but later it became clear that you’ve written him intentionally to be a sort of a gullible idiot, so I don’t have a problem with it.
One thing that is missing is the option to tell Broldor right away that you’ve already found Marcy’s body without accepting his quest first. Right now, you can find the body and read the note, but you can only finish the quest if you accept the quest from Broldor and read the note again, which isn’t very intuitive. But since that’s the only major issue I found during my testing (that isn’t related to the claim description itself, which might be slightly outdated, but we can handle that later), I think we can go ahead and consider the showcase as finished.
One minor point that I’d still like to mention is the usage of the word “crappy”. This jumped out on me as being stylistically wrong, and indeed, the word isn’t used in vanilla ESMs or TR even once. It’s good practice to check for usage of words like these and if vanilla didn’t use them, consider using more fitting synonyms instead.
Recommended for promotion!