Gabe's quest showcase

16 posts / 0 new
Last post
abby's picture
abby
Quest Reviewer
Joined:
2021-02-16 06:31
Last seen:
2 weeks 5 days ago

I did Awoke and Broke as my first showcase. Note that the dialogue and journal entries mention the sewers, but the quest actually takes place inside the inn still due to the fact that the sewers do not yet exist.

AttachmentSizeDate
Binary Data TR_getmugged.ESP6 KB2021-02-17 04:54
abby's picture
abby
Quest Reviewer
Joined:
2021-02-16 06:31
Last seen:
2 weeks 5 days ago

DOD QUESTLINE ANY% WR

EOE QUESTLINE ANY% WR

 
Dev Shah's picture
Dev Shah
Interior DeveloperQuest Reviewer
Joined:
2020-07-12 13:22
Last seen:
8 months 3 weeks ago

Reviewed it! 

The scripts and all seem to work perfectly, and the quest is really good, especially since it was made it a day!

Here are my thoughts :
 

 

- I don't like the fact that you just know that your gold is gone. It would be better if the journal just said that you saw something unusual for a sec while you were sleeping in cat-catchers, and you have to actually investigate what happened.(This way, you should even have more gold be stolen if the player doesn't follow the lead and just ignores it)
- Continuing from the first point, a dialogue chain where you have to find it out where the stealer is, and making the location less overt might be better. Might want to change the topic name to something like "something unusual." or "sleeping in the Dancing Jug" too.
- All script, global and object names should have TR_m4_q_AABIdname/ TR_m4_q_AAB_Idname as their id. (your choice between the two)
- Topic "robbed while sleeping", for journal 15, "I've said all I know." might not make sense, since the player might be asking that to someone else. 
- "You should have taken the hit and gone home, outlander." seems too boastful for a low level thief. If that's the character you were looking for, that's cool, but her first denying the robbery, then the player having the choice to either convince her to give the gold back, or just fight her might make for a better character.
- "... I suggest you go fetch a guard." kinda implies that there is an interaction with the guard. If you want to go that path, even just a denial to help from guards would be better.
-Iron key might be better named as Llavali's key just so the player can remember where the key was from.
- Might be a good idea to add some other bit of loot to the chest too, as a reward for the player ( mildly expensive trinkets with a total value < 100 gold, maybe.)
-You'll need to add SetFight 100 along with startcombat player ( since just the latter will stop the fight if the player saves and loads)
-The file isn't clean, check TESAME to clean it. ( basically remove any references you didn't touch.

 

If you do all these things and flesh out the quest a bit more, I'd be happy to recommend you for promotion! 

Take care!!

abby's picture
abby
Quest Reviewer
Joined:
2021-02-16 06:31
Last seen:
2 weeks 5 days ago

I done did it

AttachmentSizeDate
Binary Data Clean TR_getmugged.ESP18.29 KB2021-02-17 21:25

DOD QUESTLINE ANY% WR

EOE QUESTLINE ANY% WR

 
Dev Shah's picture
Dev Shah
Interior DeveloperQuest Reviewer
Joined:
2020-07-12 13:22
Last seen:
8 months 3 weeks ago

The quest looks amazing and it's really shaping up now. I'm being a bit more nitpicky now that the basic premise of the quest looks good. The suggestions are a bit much, but a lot of them are very small things. 

 

-The journal Name was right for you, I only meant it for the other things, sorry if it didn't come across properly. Quest journal name should be TR_m4_And_AwokeAndBroke.
-The guards tell you that "you say a dunmer woman..." when nothing about the dunmer woman is said before that. (since you can skip journal 10 and go straight to 15)
-Llavali doesn't talk admit it even when you loot the chest unless you talked to the guard first. Some convincing should make her admit it, atleast.
-The 'hope you choke on it' part doesn't make much sense to me, since she offers it in the first place.
-Currently, she will still give you 500 gold even if you took the gold from the chest first.
-You should remove 750 gold from the chest, not 250, if you wanna imply everything was gone. I don't think removing extra stuff from a chest is a problem anyway. It is a problem if you did it for the player, but not for the chest.
-The journal updates to 40 everytime you open it whenn the global is at 3. You should change the global to 4 after the journal updates.
-A few more greetings for Llavali, just to flesh her character out a bit more might be nice. (One for when you first meet after getting robbed, one more for the deal succesful)
-All quest related greetings should be in Greeting 5 (there should be a placeholder, BEGIN MAP 4 ANDOTHREN Greetings. You need to write after that), and forcegreetings/greetings important enough to precede disease and vampirism greetings. should be in Greeting 1 (In Greeting 1, place the dialogue near the ones simlar to you, so nearby m4 dialogue.), so you'll need to move the greeting. More info here: https://www.tamriel-rebuilt.org/content/guidelines-quests-and-dialogue
-Some cells are dirty, the only touched cell should be the Andothren one for now, you need to clean the others.
-You dirtied the dialogue above and below the greeting you placed. That needs to be cleaned too.
-There is one dialogue entry in the journal somehow.
-It might be fine here, because it only checks on Sleep, but GetDeadCount is usually performance intesive. So what I would suggest doing in the future is updating a global OnDeath and using that. (Globals are not performance intensive, so you can use them within reason.) Oh, and OnDeath only works in one script at a time, so you can't use OnDeath on both.
-LavaliScript needs to have TR_Map Variable(all NPCs need that), and maybe NoLore. Check the T_ScNPC_MW_Map4NoLore script for how to use it.
-For lavaliscript, the journal will update when you kill her even if the quest didn't start. We don't want that, so a check for if the quest started is a good idea (also remember, if you are going to use a global as I suggested, update the global independant of the check)
-The check for the key when the chest is unlocked is redundant, because you're doing the same things on both checks.
-You shouldn't check for each id seperately, you should check for the guard class. If you want some of them to have a unique dialouge, put the ID you want the unique dialogue on above the general guard class, so it'll trigger first. And you don't need to filter for both Andothren, The dancing cup and Andothren since the latter covers the former. ( In general, "abc, xyz" will be included in the filter for cell "abc")
-Also, only a few of them check for the journal index. If you want a catch all response, filter for the global you used to not be equal to 0. Otherwise, always have journal checks, don't ever rely on player not knowing the topic beforehand, since another mod might interfere/some dialogue might randomly say that sequence of words.
-You shouldn't check for Andothren, The dancing cup for Llavali, since she's going to move and it'd break things. Just remove that filter. ( In general, you shouldn't filter dialogue for a cell if you filter for a unique ID anyway, unless they are going to move.( guards are an exception, since multiple of them use the same id))
-I don't quite like the topic name "lighter bags", since this makes the player thing about the weight of all the gold, and kinda ruins the immersion. I wouldn't really hold this up for a promotion, but a better one will be nice for the actual claim.
-Use Editor_Marker.nif for the activator. It'll turn it invisible.
-You can remove all the elseif's for the activate, and just have the activate after the check. Like so:

if ( OnActivate )
    if ( GetLocked )
        if ( VarName == 1 )
            do x
        elseif ( VarName == 2 )
            do y
        endif

        Activate
    .
    .
    .
    endif
endif

I think this is good so far, pretty close to promotion!

Take care!!

abby's picture
abby
Quest Reviewer
Joined:
2021-02-16 06:31
Last seen:
2 weeks 5 days ago

Alright, here's the next iteration. I think this should just about clear it up, but I could be wrong.

AttachmentSizeDate
Binary Data Clean Clean Clean Clean TR_getmugged.ESP16.13 KB2021-02-20 06:06

DOD QUESTLINE ANY% WR

EOE QUESTLINE ANY% WR

 
abby's picture
abby
Quest Reviewer
Joined:
2021-02-16 06:31
Last seen:
2 weeks 5 days ago

I was wrong. Here's the next next iteration, this time cleaned for real.

AttachmentSizeDate
Binary Data Clean^7 TR_getmugged.esp15.92 KB2021-02-20 07:43

DOD QUESTLINE ANY% WR

EOE QUESTLINE ANY% WR

 
Dev Shah's picture
Dev Shah
Interior DeveloperQuest Reviewer
Joined:
2020-07-12 13:22
Last seen:
8 months 3 weeks ago

Looking pretty good in the cs. I love the things you did with the choices. Unfortunately I wasn't able to playtest it, since it crashes on startup, because you forgot to rename the journal name in scripts. 

 

This should be pretty close to promotion! Maybe the next version?

Take care!!

abby's picture
abby
Quest Reviewer
Joined:
2021-02-16 06:31
Last seen:
2 weeks 5 days ago

This time, it doesn't instantly break

AttachmentSizeDate
Binary Data Super Duper Clean TR_getmugged.esp15.95 KB2021-02-21 06:16

DOD QUESTLINE ANY% WR

EOE QUESTLINE ANY% WR

 
abby's picture
abby
Quest Reviewer
Joined:
2021-02-16 06:31
Last seen:
2 weeks 5 days ago

alright, for real now

AttachmentSizeDate
Binary Data TR_getmugged_forreal.esp15.69 KB2021-02-21 07:21

DOD QUESTLINE ANY% WR

EOE QUESTLINE ANY% WR

 
abby's picture
abby
Quest Reviewer
Joined:
2021-02-16 06:31
Last seen:
2 weeks 5 days ago

when

AttachmentSizeDate
Binary Data Clean TR_getmugged_forreal.esp15.84 KB2021-02-21 07:43

DOD QUESTLINE ANY% WR

EOE QUESTLINE ANY% WR

 
Dev Shah's picture
Dev Shah
Interior DeveloperQuest Reviewer
Joined:
2020-07-12 13:22
Last seen:
8 months 3 weeks ago

Reviewed again, hopefully for the second-last time. Wasn't able to playtest some of it cause it was broken. In general, you should probably playtest a ton before sending a claim too. It's like half the work smiley

 

 

the review

-You accidentally misfiltered the first greeting of Llavali to someone else.
-Using "I see" or the other choice if player level > 5 as a choice on Llavali leads to an infinite loop. (since the one with the other choices also has it filtered as Pc Level <5, so it'll never work)
-Right now the greetings are in-between the greetings of a single npc. Generally, you should avoid that.
-I would have the guard say something even when the journal is less than 10.
-Gold will be removed from your inventory even if you have none in the choice where you give Llavali the gold.(On a similar note, the game acts as if you took the gold even though you didnt. Might be a good idea to try and see if you can know if the player took them or not).
-Some more greetings for Llavali should be good. (Like when you take her gold)
-Some ending dialogue for topic "missing gold" is needed. Ideally, the topic shouldn't just go away, there should be an ending for the main people about it.
-The "her stash is empty" journal even triggers if the container is locked ( you removed the requirement for the key somehow.)
 

Take care!!

abby's picture
abby
Quest Reviewer
Joined:
2021-02-16 06:31
Last seen:
2 weeks 5 days ago

this time, I playtested it all by myself

AttachmentSizeDate
Binary Data TR_getmugged_super_final_version.esp16.18 KB2021-02-21 20:50

DOD QUESTLINE ANY% WR

EOE QUESTLINE ANY% WR

 
Dev Shah's picture
Dev Shah
Interior DeveloperQuest Reviewer
Joined:
2020-07-12 13:22
Last seen:
8 months 3 weeks ago

The dialogue seems awesome and the choices and stuff was solid. I'm recommending for promotion , and I'll fix the things listed below on a proper review

General guidelines-
-NotLocal NoLore = 0 filter for dialogue is needed from basically anything that isn't filtered with ID.(there can be some exceptions) Not sure how I forgot that.
-'Dead' dialogue filter can be fps intensive, so if you're updating the journal anyways, using the journal entry might be more efficient. (it can be used if there's no alternative, though)

Things to fix - 

 

Things to fix-
-An argument can be made that the player should be able to confront her before getting her name from the guards.
-there's an extra activate in containerscript that isn't needed
-I'd remove "For the night" in the journal, since the player might've just slept for an hour.
-You don't need End scriptname. Just end works.
-I'd maybe have Llavali's full name in the dialogue.
-Change the conditions from >15, dead to == 30 (since that's the only thing that could happen, and is less fps intensive)
-Add NotLocal NoLore == 0 check for generic dialogue guards and the customers.
-Maybe a little less disposition  check or telling you about the dunmer woman.
-Haven't you->have you for the greeting.
-Moneystolen == -1 never needs the dialogue with Llavali, since as far as I can see, so the dialogue should be deleted.
-Add dumner woman instead of woman in journal.
-Add finished to journal 45.
-Add an entry for missing gold for the people in the inn so that it doesn't go away instanty, and maybe just remove the 'so you killed her' (and the guards).(what I meant to say in the previous review was to just give the dialogue to Llavali. Sorry, "main characters" was too vague and was meant as a general statement)
-I'd rename the chest to something like "Llavali's stash"
-Move the greetings so that they are not in-between the greetings of the same npc.

Take care!!

Jani's picture
Jani
ModeratorInterior DeveloperQuest Developer
Joined:
2017-10-08 01:57
Last seen:
1 hour 37 min ago

Promoted. Congrats!

Why's picture
Why
Interior DeveloperQuest Reviewer
Joined:
2014-01-02 23:58
Last seen:
1 month 1 week ago

Promoted, contratulations and welcome to the team!
edit: ninja'd by Jani!